src/coordinator/mod.rs

@@ -131,11 +131,7 @@ impl<'a> CoordState<'a> {
         let conn_string: String = {
             let read_settings = self.settings.read().await;
 
-            format!(
+            format!("ws://{}:{}", read_settings.camera_ip, read_settings.camera_port.to_string())
-                "ws://{}:{}",
-                read_settings.camera_ip,
-                read_settings.camera_port.to_string()
-            )
         };
 
         match connect_async(conn_string).await {
@@ -169,21 +165,20 @@ impl<'a> CoordState<'a> {
         let conn_string: String = {
             let read_settings = self.settings.read().await;
 
-            format!(
+            format!("ws://{}:{}", read_settings.tracker_ip, read_settings.tracker_port.to_string())
-                "ws://{}:{}",
-                read_settings.tracker_ip,
-                read_settings.tracker_port.to_string()
-            )
         };
 
-        self.rt.spawn(remote_video_loop(
+        self.rt.spawn(
-            conn_string,
+            remote_video_loop(
-            self.pipeline.sink_frame.clone(),
+                conn_string,
-            self.to_mec.clone(),
+                self.pipeline.sink_frame.clone(),
-            self.keep_windows_pipe_alive.clone(),
+                self.to_mec.clone(),
-            self.tracker_state.clone(),
+                self.keep_windows_pipe_alive.clone(),
-            self.rt.clone(),
+                self.tracker_state.clone(),
-        ));
+                self.rt.clone()
+            ),
+        );
+
     }
 
     pub async fn check_states(&mut self) {
@@ -195,7 +190,9 @@ impl<'a> CoordState<'a> {
             ));
         }
 
-        if !self.keep_windows_pipe_alive.load(Ordering::SeqCst) {}
+        if !self.keep_windows_pipe_alive.load(Ordering::SeqCst) {
+
+        }
 
         if !self.sck_alive_server.load(Ordering::SeqCst) {
             info!("Restarting socket server");

src/coordinator/remote_video_processor.rs

@@ -94,6 +94,7 @@ pub async fn remote_video_loop(
 
                     // rate limit updates
                     sleep_until(Instant::now() + Duration::from_millis(50)).await;
+
                 }
             }
         }

src/gstreamer_pipeline.rs

@@ -30,9 +30,6 @@ impl WebcamPipeline {
         let convert = ElementFactory::make("videoconvert")
             .build()
             .expect("Could not build video convert for GStreamer");
-        let rate = ElementFactory::make("videorate")
-            .build()
-            .expect("Could not build the video rate element");
 
         let tee = ElementFactory::make("tee")
             .build()
@@ -54,10 +51,11 @@ impl WebcamPipeline {
             .build()
             .expect("Could not build videoscale for GStreamer");
 
-        let caps_string = "video/x-raw,format=RGB,width=640,height=480,max-buffers=1,drop=true";
+        let caps_string =
+            String::from("video/x-raw,format=RGB,width=640,height=480,max-buffers=1,drop=true");
         // let caps_string = String::from("video/x-raw,format=RGB,max-buffers=1,drop=true");
         let appsrc_caps =
-            gstreamer::Caps::from_str(caps_string).expect("Couldn't create appsrc caps");
+            gstreamer::Caps::from_str(&caps_string).expect("Couldn't create appsrc caps");
 
         /*
         // let sink_frame = ElementFactory::make("appsink")
@@ -84,7 +82,6 @@ impl WebcamPipeline {
             .add_many(&[
                 &source,
                 &convert,
-                &rate,
                 &tee,
                 &queue_app,
                 &sink_paintable,
@@ -97,14 +94,7 @@ impl WebcamPipeline {
         source
             .link(&convert)
             .expect("Could not link video source to converter");
-        
+        convert.link(&tee).expect("Could not link converter to tee");
-        convert.link(&rate)
-            .expect("Could not link rate to tee");
-
-        rate.link_filtered(
-            &tee,
-            &gstreamer::caps::Caps::from_str("video/x-raw,framerate=15/1").expect("Could not build framerate caps"),
-        ).expect("Could not link converter to rate");
 
         let tee_src_1 = tee
             .request_pad_simple("src_%u")

src/main.rs

@@ -1,17 +1,17 @@
-use gtk::prelude::{ApplicationExt, ApplicationExtManual};
 use gtk::{glib, Application};
 use log::{error, info};
+use gtk::prelude::{ApplicationExt, ApplicationExtManual};
 use simplelog::SimpleLogger;
 use std::{env, sync::Arc};
 use tokio::{runtime, sync::RwLock};
 
 use crate::config::load_config;
 
-mod config;
 mod coordinator;
 mod gstreamer_pipeline;
 mod joystick_source;
 mod remote_sources;
+mod config;
 mod ui;
 const APP_ID: &str = "net.nickiel.joystick-controller-client";
 
@@ -50,3 +50,4 @@ fn main() -> glib::ExitCode {
 
     exit_code
 }
+

src/ui/mod.rs

@@ -14,13 +14,14 @@ use crate::config::AppConfig;
 use crate::coordinator::{start_coordinator, ApplicationEvent, MoveEvent};
 use crate::remote_sources::TrackerState;
 
-mod settings_modal;
 mod socket_panel;
 mod tracker_panel;
+mod settings_modal;
 
 use socket_panel::SocketPanel;
 use tracker_panel::TrackerPanel;
 
+
 pub enum GuiUpdate {
     SocketState(bool),
     MoveEvent(MoveEvent),
@@ -83,6 +84,7 @@ pub fn on_activate(app: &Application) {
 
     app.set_menubar(Some(&menubar));
     info!("Menu bar set up");
+
 }
 
 pub fn build_ui(app: &Application, config: Arc<RwLock<AppConfig>>, runtime: Handle) {
@@ -99,6 +101,7 @@ pub fn build_ui(app: &Application, config: Arc<RwLock<AppConfig>>, runtime: Hand
         .child(&main_box)
         .build();
 
+
     let rt = runtime.clone();
     let config_modal_config = config.clone();
     let connections_activate = gio::ActionEntry::builder("connections")
@@ -111,6 +114,7 @@ pub fn build_ui(app: &Application, config: Arc<RwLock<AppConfig>>, runtime: Hand
 
     app.add_action_entries([connections_activate]);
 
+
     // Main Event Channel
     let (to_mec, mec) = async_channel::unbounded::<ApplicationEvent>();
     let (to_gui, gui_recv) = async_channel::bounded::<GuiUpdate>(10);

src/ui/settings_modal.rs

@@ -1,16 +1,14 @@
 use std::sync::Arc;
 
 use gtk::glib::{self, clone};
-use gtk::{
+use gtk::{prelude::{BoxExt, ButtonExt, EditableExt}, Application, ApplicationWindow, Box, Button, Entry, Label, Window};
-    prelude::{BoxExt, ButtonExt, EditableExt},
-    Application, ApplicationWindow, Box, Button, Entry, Label, Window,
-};
-use log::{error, info};
 use tokio::runtime::Handle;
 use tokio::sync::RwLock;
+use log::{error, info};
 
 use crate::config::{save_config, AppConfig};
 
+
 pub struct ConnectionsModal {
     pub window: Window,
 
@@ -18,14 +16,10 @@ pub struct ConnectionsModal {
 }
 
 impl ConnectionsModal {
-    pub fn new(
+    pub fn new(app: &Application, parent: &ApplicationWindow, rt: &Handle, app_config: &Arc<RwLock<AppConfig>>) -> Self {
-        app: &Application,
+        
-        parent: &ApplicationWindow,
-        rt: &Handle,
-        app_config: &Arc<RwLock<AppConfig>>,
-    ) -> Self {
         // Send help :(
-        let config_read = rt.block_on(async { app_config.read().await });
+        let config_read = rt.block_on(async {app_config.read().await});
 
         let main_box = gtk::Box::new(gtk::Orientation::Vertical, 0);
 
@@ -120,38 +114,39 @@ impl ConnectionsModal {
         main_box.append(&quit_button);
 
         let new_ref = app_config.clone();
-        quit_button.connect_activate(clone!(
+        quit_button
-            @strong rt,
+            .connect_activate(clone!(
-            @weak camera_ip_entry, @weak camera_port_entry,
+                @strong rt,
-            @weak tracker_ip_entry, @weak tracker_port_entry,
+                @weak camera_ip_entry, @weak camera_port_entry,
-            @weak tracker_refresh_millis => move |_| {
+                @weak tracker_ip_entry, @weak tracker_port_entry,
+                @weak tracker_refresh_millis => move |_| {
 
-                let new_camera_ip = camera_ip_entry.text().to_string();
+                    let new_camera_ip = camera_ip_entry.text().to_string();
-                let new_camera_port = camera_port_entry.text().parse::<u32>().unwrap();
+                    let new_camera_port = camera_port_entry.text().parse::<u32>().unwrap();
 
-                let new_tracker_ip = tracker_ip_entry.text().to_string();
+                    let new_tracker_ip = tracker_ip_entry.text().to_string();
-                let new_tracker_port = tracker_port_entry.text().parse::<u32>().unwrap();
+                    let new_tracker_port = tracker_port_entry.text().parse::<u32>().unwrap();
-                let new_tracker_millis = tracker_refresh_millis.text().parse::<u32>().unwrap();
+                    let new_tracker_millis = tracker_refresh_millis.text().parse::<u32>().unwrap();
 
-                {
+                    {
-                    // maybe just send the police.
+                        // maybe just send the police. 
-                    let mut write_lock = rt.block_on(async {new_ref.write().await});
+                        let mut write_lock = rt.block_on(async {new_ref.write().await});
 
-                    write_lock.camera_ip = new_camera_ip;
+                        write_lock.camera_ip = new_camera_ip;
-                    write_lock.camera_port = new_camera_port;
+                        write_lock.camera_port = new_camera_port;
 
-                    write_lock.tracker_ip = new_tracker_ip;
+                        write_lock.tracker_ip = new_tracker_ip;
-                    write_lock.tracker_port = new_tracker_port;
+                        write_lock.tracker_port = new_tracker_port;
-                    write_lock.tracker_refresh_rate_millis = new_tracker_millis;
+                        write_lock.tracker_refresh_rate_millis = new_tracker_millis;
-                    // why does this feel like the borrow checker gave me a pass?
+                        // why does this feel like the borrow checker gave me a pass?
-                    if let Err(e) = save_config(&write_lock.to_owned()) {
+                        if let Err(e) = save_config(&write_lock.to_owned()) {
-                        error!("Could not save config! {e}");
+                            error!("Could not save config! {e}");
+                        }
+                        // FBI!!! OPEN UP!!!!
                     }
-                    // FBI!!! OPEN UP!!!!
-                }
 
-                info!("Please nicholas, add a non-crashing parse");
+                    info!("Please nicholas, add a non-crashing parse");
-        }));
+            }));
 
         ConnectionsModal {
             window,

src/ui/socket_panel.rs

@@ -1,8 +1,6 @@
 use async_channel::Sender;
 use gtk::{
-    glib,
+    glib, prelude::{BoxExt, ButtonExt}, Box, Button
-    prelude::{BoxExt, ButtonExt},
-    Box, Button,
 };
 use log::error;
 
@@ -39,11 +37,13 @@ impl SocketPanel {
         &self.top_level
     }
 
+
     pub fn button_label(&self, new_label: &str) {
         self.connect_button.set_label(new_label);
     }
 
     pub fn connect_button_callback(&self, to_mec: Sender<ApplicationEvent>) {
+
         self.connect_button.connect_clicked(glib::clone!(@strong to_mec => move |_button| {
                 match to_mec.try_send(ApplicationEvent::StartCameraSocket) {
                     Ok(_) => {},